remove help view

there was only a link to the rtd documentation (now directly linked from a "Documentation" navbar entry) and
some duplicate router configuration that was also shown (even with the correct values) when adding a host.

the help page html was not valid due to the values inserted into the router configuration help.

help/documentation policy: add static help to the docs, add dynamic help directly at the places (in the views) where needed

nsupdate/main/templates/main/help.html

@@ -1,17 +0,0 @@
-{% extends "base.html" %}
-{% load bootstrap %}
-
-{% block content %}
-<h1>Documentation</h1>
-    We have nice documentation for service users and administrators there:
-
-    <a href="//nsupdateinfo.readthedocs.org/">nsupdate.info docs on ReadTheDocs.org</a>
-
-<h1>Configuration Help</h1>
-<div class="row">
-    <div class="well">
-        <h3>How to configure automated dynamic DNS updates?</h3>
-        {% include "main/includes/tabbed_router_configuration.html" with host=object %}
-    </div>
-</div>
-{% endblock %}

nsupdate/main/urls.py

@@ -2,7 +2,7 @@ from django.conf.urls import patterns, url
 from django.views.generic import TemplateView
 
 from .views import (
-    HomeView, OverviewView, HostView, DeleteHostView, AboutView, HelpView, GenerateSecretView, GenerateNSSecretView,
+    HomeView, OverviewView, HostView, DeleteHostView, AboutView, GenerateSecretView, GenerateNSSecretView,
     RobotsTxtView, DomainOverwievView, DomainView, DeleteDomainView, ScreenshotsView)
 from ..api.views import (
     MyIpView, DetectIpView, AjaxGetIps, NicUpdateView, AuthorizedNicUpdateView)
@@ -14,7 +14,6 @@ urlpatterns = patterns(
     url(r'^about/$', AboutView.as_view(), name="about"),
     url(r'^legal/$',
         TemplateView.as_view(template_name='main/legal.html'), name="legal"),
-    url(r'^help/$', HelpView.as_view(), name="help"),
     url(r'^screenshots/$', ScreenshotsView.as_view(), name="screenshots"),
     url(r'^overview/$', OverviewView.as_view(), name='overview'),
     url(r'^host/(?P<pk>\d+)/$', HostView.as_view(), name='host_view'),

nsupdate/main/views.py

@@ -86,15 +86,6 @@ class HomeView(TemplateView):
         return context
 
 
-class HelpView(TemplateView):
-    template_name = "main/help.html"
-
-    def get_context_data(self, *args, **kwargs):
-        context = super(HelpView, self).get_context_data(*args, **kwargs)
-        context['nav_help'] = True
-        return context
-
-
 class ScreenshotsView(TemplateView):
     template_name = "main/screenshots.html"
 

nsupdate/templates/base.html

@@ -43,8 +43,9 @@
                         <li{% if nav_about %} class="active"{% endif %}>
                             <a href="{% url 'about' %}">About</a>
                         </li>
-                        <li{% if nav_help %} class="active"{% endif %}>
-                            <a href="{% url 'help' %}">Help</a>
+                        <li>
+                            <a href="http://nsupdateinfo.readthedocs.org/"
+                               class="navbar-link" title="Open docs in new window" target="_blank">Documentation</a>
                         </li>
                     </ul>
                     <ul class="nav navbar-nav pull-right">