flo/nsupdate.info
1
0
Fork 0
Code Issues 1 Pull Requests 2 Packages Releases Activity

update api: there is no "noauth" return value, it must be "badauth"

Browse Source
This commit is contained in:
Thomas Waldmann 2013-11-16 06:09:56 +01:00
parent 89e18d9d65
commit 925ad20405
2 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
nsupdate/api/_tests/test_api.py
View File

@ -17,9 +17,10 @@ def test_myip(client):
assert response.content in ['127.0.0.1', '::1'] assert response.content in ['127.0.0.1', '::1']
def test_nic_update(client): def test_nic_update_noauth(client):
response = client.get(reverse('nic_update')) response = client.get(reverse('nic_update'))
assert response.status_code == 401 assert response.status_code == 401
assert response.content == "badauth"
def make_basic_auth_header(username, password): def make_basic_auth_header(username, password):
@ -27,6 +28,13 @@ def make_basic_auth_header(username, password):
return "Basic " + base64.b64encode("%s:%s" % (username, password)) return "Basic " + base64.b64encode("%s:%s" % (username, password))
def test_nic_update_badauth(client):
response = client.get(reverse('nic_update'),
HTTP_AUTHORIZATION=make_basic_auth_header(TEST_HOST, "wrong"))
assert response.status_code == 401
assert response.content == "badauth"
def test_nic_update_authorized(client): def test_nic_update_authorized(client):
response = client.get(reverse('nic_update'), response = client.get(reverse('nic_update'),
HTTP_AUTHORIZATION=make_basic_auth_header(TEST_HOST, TEST_SECRET)) HTTP_AUTHORIZATION=make_basic_auth_header(TEST_HOST, TEST_SECRET))

2
nsupdate/api/views.py
View File

@ -184,7 +184,7 @@ class NicUpdateView(View):
auth = request.META.get('HTTP_AUTHORIZATION') auth = request.META.get('HTTP_AUTHORIZATION')
if auth is None: if auth is None:
logger.warning('%s - received no auth' % (hostname, )) logger.warning('%s - received no auth' % (hostname, ))
return basic_challenge("authenticate to update DNS", 'noauth') return basic_challenge("authenticate to update DNS", 'badauth')
username, password = basic_authenticate(auth) username, password = basic_authenticate(auth)
if not check_api_auth(username, password): if not check_api_auth(username, password):
logger.warning('%s - received bad credentials, username: %s' % (hostname, username, )) logger.warning('%s - received bad credentials, username: %s' % (hostname, username, ))